Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not get actual ns_view when it's replace by setContentView #710

Merged
merged 2 commits into from
Mar 6, 2023
Merged

fix: not get actual ns_view when it's replace by setContentView #710

merged 2 commits into from
Mar 6, 2023

Conversation

BillGoldenWater
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

Other information

@BillGoldenWater BillGoldenWater requested a review from a team as a code owner March 6, 2023 15:23
@wusyong wusyong merged commit 76ae625 into tauri-apps:dev Mar 6, 2023
@github-actions github-actions bot mentioned this pull request Mar 6, 2023
Merged
@wusyong wusyong mentioned this pull request Mar 6, 2023
Closed
amrbashir pushed a commit that referenced this pull request Mar 7, 2023
@BillGoldenWater @amrbashir
fix: not get actual ns_view when it's replace by setContentView (#710)
c52c284 
* fix: not get actual ns_view when it's replace by setContentView

* add change file
@github-actions github-actions bot mentioned this pull request May 6, 2023
Merged
amrbashir added a commit that referenced this pull request Jul 26, 2023
@amrbashir
fix(macos): fix WindowExtMacOS::ns_view invalid pointer
656d49e 
continuation of #710
@amrbashir amrbashir mentioned this pull request Jul 26, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] (macOS) reset size when move cross monitor that has different scale factor
2 participants
@BillGoldenWater @wusyong