Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(macOS): windows frozen when starting in fullscreen #727

Merged
merged 1 commit into from
May 4, 2023
Merged

fix(macOS): windows frozen when starting in fullscreen #727

merged 1 commit into from
May 4, 2023

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented May 4, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

I remove this check to prevent from deadlock.
It may produce redundant event but I feel like it should be harmless.

@wusyong wusyong requested a review from a team as a code owner May 4, 2023 07:17
@amrbashir amrbashir merged commit 7159466 into dev May 4, 2023
@amrbashir amrbashir deleted the fix/fullscreen-hang.md branch May 4, 2023 11:38
@github-actions github-actions bot mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees

@amrbashir amrbashir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wusyong @amrbashir