Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): leak when updating tray icon or tooltip #755

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix(windows): leak when updating tray icon or tooltip #755

merged 1 commit into from
Jul 3, 2023

Conversation

Lej77
Copy link
Contributor

@Lej77 Lej77 commented Jul 3, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

Other information

@Lej77 Lej77 requested a review from a team as a code owner July 3, 2023 17:16
@Lej77 Lej77 mentioned this pull request Jul 3, 2023
Closed
2 tasks
@amrbashir
Copy link
Member

Thank you

@amrbashir amrbashir changed the title fix(windows): leak when updating tray icon or tooltip (fix #753) fix(windows): leak when updating tray icon or tooltip Jul 3, 2023
@amrbashir amrbashir merged commit e9875fe into tauri-apps:dev Jul 3, 2023
9 checks passed
@github-actions github-actions bot mentioned this pull request Jul 3, 2023
Merged
amrbashir pushed a commit that referenced this pull request Jul 3, 2023
@Lej77 @amrbashir
fix(windows): leak when updating tray icon or tooltip (#755)
e40b4aa
@amrbashir
Copy link
Member

cherry picked into v0.16 branch in e40b4aa

This was referenced Jul 3, 2023
Closed
Merged
@Lej77 Lej77 deleted the fix-tray-icon-leak-on-windows branch July 3, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Icon leaked by tao::system_tray::SystemTray::set_icon on Windows
2 participants
@Lej77 @amrbashir