fix(macOS): fix SystemTrayEvent
not emitted after calling set_menu
#764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
SystemTrayEvent
on macOS (fail to set tray menu & fail to get callback) tauri#7364 [bug] On MacOS when a new system_tray_menu is set the on_system_tray_event handler is no longer called tauri#5842Other information
We didn't set the tray menu direct to
ns_status_bar
. Instead, we set it totray_target.menu
and let thetray_target
attach it when we click the tray icon.tao/src/platform_impl/macos/system_tray.rs
Lines 91 to 98 in 731e397
However, when calling the
set_menu
, it sets the new menu tons_status_bar
, nottray_target
. Therefore the customized click handler is not triggeredtao/src/platform_impl/macos/system_tray.rs
Lines 146 to 150 in 731e397