Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: platform_impl::ios::view::application_continue return type #787

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

logankeenan
Copy link
Sponsor Contributor

What kind of change does this PR introduce?

The return type of the application_continue should be NO rather than false. This is currently causing a complication error.

error:

error[E0308]: mismatched types
   --> /Users/logankeenan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tao-0.22.1/src/platform_impl/ios/view.rs:569:16
    |
565 |   ) -> BOOL {
    |        ---- expected `i8` because of return type
...
569 |         return false;
    |                ^^^^^ expected `i8`, found `bool`

For more information about this error, try `rustc --explain E0308`.
error: could not compile `tao` (lib) due to previous error
  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir amrbashir merged commit 65ebab8 into tauri-apps:dev Aug 16, 2023
9 checks passed
@github-actions github-actions bot mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants