refactor: Merge workspace into single package. #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2023
|
@lucasfernog any last arguments to convince me not to do it? :D |
lucasfernog
approved these changes
Feb 6, 2023
|
Just do it :D let's see how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no logic changes other than added support for pnpm detection. While i was at it i changed the package manager to pnpm like we did with the plugins repo.
The intend of this PR is to make the repo easier to maintain, use, and contribute to.
This PR should serve as an interim step, or an alternative to #355 because imo this action has too many users to remove most of it's feature before v1, but at the same time i think it's not in the state to be v1 -> the latter i'm trying to solve so that we can have a stable v1 and then we can look at Jonas' PR for v2 or v3, or maybe opt into a completely separate action.