-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: remove broken configPath
option
#428
Conversation
@lucasfernog 2 questions:
|
The I think this use case was never perfectly implemented and it's ok to slowly remove it. We'll probably implement this kind of thing with a different service. About the projectPath thing: I think |
Yeah that doesn't work right now. I meant to fix it but thought it'd be way easier to just remove this option and let users use the normal
Gonna check that but sounds about right 🤔 |
This may seem extreme at first but let's be honest, this option never did what you expect and removing it will move it closer to the local cli usage.
TODO:
Edit: A few successful runs:
https://github.com/FabianLars/tauri-action-testbed/actions/runs/4665698961
https://github.com/FabianLars/tauri-action-testbed/actions/runs/4665905996