Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle nsis builds, closes #436 #446

Merged
merged 8 commits into from
May 3, 2023
Merged

feat: Handle nsis builds, closes #436 #446

merged 8 commits into from
May 3, 2023

Conversation

FabianLars
Copy link
Member

@FabianLars FabianLars commented May 2, 2023

A few successful runs: https://github.com/FabianLars/tauri-action-testbed/actions. The uploaded json file looked as expected in the Release :)

@FabianLars FabianLars changed the title feat: Handle nsis builds, closes #435 feat: Handle nsis builds, closes #436 May 2, 2023
@FabianLars FabianLars linked an issue May 2, 2023 that may be closed by this pull request
@wusyong
Copy link
Member

wusyong commented May 3, 2023

oops didn't realize both PR can't merge at the same time.
@FabianLars can you help me resolve those conflicts?

@FabianLars
Copy link
Member Author

Sure, gimme a second. That's why i always merge my PRs here before i even start working on new ones :D

@FabianLars FabianLars merged commit 0ba09ea into dev May 3, 2023
2 checks passed
@FabianLars FabianLars deleted the nsis branch May 3, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new NSIS windows target
2 participants