fix: Fixed MSI build version inconsistency #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran the gh action to build my app there's a version inconsistency in the artifact.
The build version is
0.3.0-1but then somewhere the msi builder changes it to0.3.0.1and then when the gh action finishes the build, it looks for the file with the version0.3.0-1but it can't find it, because the file is under the name of0.3.0.1.Running candle for "main.wxs" Running light to produce path\to\project\src-tauri\target\release\bundle\msi\Packager By Waypoint_0.3.0.1_x64_en-US.msi Bundling path\to\project\src-tauri\target\release\bundle\msi\Packager By Waypoint_0.3.0.1_x64_en-US.msi.zip Finished 1 bundle at: + path\to\project\src-tauri\target\release\bundle\msi\Packager By Waypoint_0.3.0.1_x64_en-US.msi path\to\project\src-tauri\target\release\bundle\msi\Packager By Waypoint_0.3.0.1_x64_en-US.msi.zip (updater) Finished 1 updater signature at: path\to\project\src-tauri\target\release\bundle\msi\Packager By Waypoint_0.3.0.1_x64_en-US.msi.zip.sig Looking for artifacts in: -path\to\project\src-tauri\target\release\bundle\msi\Packager By Waypoint_0.3.0-1_x64_en-US.msi path\to\project\src-tauri\target\release\bundle\msi\Packager By Waypoint_0.3.0-1_x64_en-US.msi.zip path\to\project\src-tauri\target\release\bundle\msi\Packager By Waypoint_0.3.0-1_x64_en-US.msi.zip.sig path\to\project\src-tauri\target\release\bundle\nsis\Packager By Waypoint_0.3.0-1_x64-setup.exe path\to\project\src-tauri\target\release\bundle\nsis\Packager By Waypoint_0.3.0-1_x64-setup.nsis.zip path\to\project\src-tauri\target\release\bundle\nsis\Packager By Waypoint_0.3.0-1_x64-setup.nsis.zip.sig