Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(features): update positioner page #1933

Merged
merged 20 commits into from
Mar 21, 2024

Conversation

dklassic
Copy link
Contributor

@dklassic dklassic commented Mar 7, 2024

What kind of changes does this PR include?

  • New or updated content
    • Update /features/positioner page

Description

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6eae13d
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/65fc3760ac638e0008635e7a
😎 Deploy Preview https://deploy-preview-1933--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dklassic dklassic marked this pull request as ready for review March 7, 2024 11:13
@dklassic dklassic requested a review from a team as a code owner March 7, 2024 11:13
Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, left a note about the structure, but feel free to try something else if you have a different idea

src/content/docs/features/positioner.mdx Outdated Show resolved Hide resolved
@FabianLars
Copy link
Member

One thing that's missing is mentioning the tray-icon feature flag which is required for the tray apis but not enabled by default

@dklassic
Copy link
Contributor Author

One thing that's missing is mentioning the tray-icon feature flag which is required for the tray apis but not enabled by default

Nice catch! Could've sworn I intended to add that but end up didn't.

Copy link

socket-security bot commented Mar 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/astro@4.5.7 Transitive: environment, eval, filesystem, network, shell, unsafe +276 46.9 MB fredkschott
npm/typescript@5.4.2 None 0 32.4 MB typescript-bot

🚮 Removed packages: npm/@astrojs/markdown-remark@4.3.1, npm/astro@4.5.8, npm/typescript@5.4.3

View full report↗︎

Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
@FabianLars FabianLars merged commit a7975ff into tauri-apps:next Mar 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Create Positioner guide
4 participants