Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next-js.mdx with correct bunx installation command. #2041

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

adityabrahmankar
Copy link

Fixed the bunx create next-app command.

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content
  • Translated content
  • Changes to the docs site code
  • Something else!

Description

  • Closes #
  • What does this PR change? Give us a brief description.
  • Did you change something visual? A before/after screenshot can be helpful.

Fixed the bunx create next-app command.
@adityabrahmankar adityabrahmankar requested a review from a team as a code owner April 5, 2024 16:33
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for tauri ready!

Name Link
🔨 Latest commit 53ac229
🔍 Latest deploy log https://app.netlify.com/sites/tauri/deploys/6616817afbce1100085a455b
😎 Deploy Preview https://deploy-preview-2041--tauri.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vasfvitor
Copy link
Contributor

vasfvitor commented Apr 8, 2024

Hi, thanks for catching this, but Next.js docs says it is the way current it is create-next-app. I haven't tested https://nextjs.org/docs/pages/api-reference/create-next-app so maybe it's outdated?
image

If you have tested it to be different, let me know so I can reopen this and test myself. Then we can open a issue upstream to make sure it's not just a typo

@vasfvitor vasfvitor closed this Apr 8, 2024
@adityabrahmankar
Copy link
Author

image

bun create next-app is the correct way which works as shown in the official bun documentation.

@vasfvitor vasfvitor reopened this Apr 8, 2024
@FabianLars
Copy link
Member

It has to be bun create instead of bunx create then though, right? Since bunx is an alias for bun x (the binary run command) I assume it will cause issues? I don't have bun installed / I'm not home so I can't test this rn

Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here what I get on windows, fresh bun out of the oven:
bunx create-next-app --use-bun error
bunx create next-app --use-bun works
same with bun

Oddly, yesteday, on next.js changed the docs to the current non working case
https://www.github.com/vercel/next.js/pull/64151

On bun cli it states it should be not dashed https://github.com/oven-sh/bun/blob/main/src/cli.zig#L1669

In a quick test, I noticed that bunx create whatever-app is an alias to create-wahatver-app, so bunx create tauri-app works to as create-tauri-app.

Again, thanks for bringing this up and citing the source docs which I should have looked at myself.

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone, LGTM ✅

@dreyfus92 dreyfus92 merged commit 369f5a5 into tauri-apps:dev Apr 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants