Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Event naming differences #3731

Open
JonasKruckenberg opened this issue Mar 18, 2022 · 0 comments
Open

[bug] Event naming differences #3731

JonasKruckenberg opened this issue Mar 18, 2022 · 0 comments
Labels
scope: api.js The @tauri-apps/api npm package type: feature request

Comments

@JonasKruckenberg
Copy link
Contributor

JonasKruckenberg commented Mar 18, 2022 •
edited

Describe the bug

The rust API names the resized event WindowEvent::Resized while the JavaScript API calls it tauri://resize.
Similarly the rust API names file drop events Dropped Hovered and Cancelled while javascript names are present tense: file-drop-hover, file-drop and file-drop-cancelled. (Notice how the last is actually a different tense too)

The naming is not horribly off, but we should consider making it consistent.

Reproduction

No response

Expected behavior

No response

Platform and versions

N/A

Stack trace

No response

Additional context

No response
@JonasKruckenberg JonasKruckenberg added type: bug scope: api.js The @tauri-apps/api npm package type: enhancement and removed type: bug labels Mar 18, 2022
@JonasKruckenberg JonasKruckenberg changed the title [bug] resized event naming mismatch [bug] Event naming differences Mar 18, 2022
@lucasfernog lucasfernog mentioned this issue Jul 3, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: api.js The @tauri-apps/api npm package type: feature request
Projects
Roadmap
Status: 📬Proposal
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucasfernog @JonasKruckenberg