-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use QTWebEngine instead of webkitgtk #4554
Comments
or use CEF for the front web engine? tauri can support multiengine. such as webview2, wkwebview, webkitgtk, cef, something else. |
Agree i think adding support for qtwebengine and not replace webkitgtk is better for a framework, as devs can decide what fits best |
I'm just gonna lazily post one of my discord messages about this into here:
Some more problems on top:
Honestly as i see it, qtwebengine is the most unlikely addition. |
Can I ask what's weird about the licensing? It seems to be LGPL these days, would that not work for this project? |
Well, since we'd need more than just qtwebengine alone, we'd probably hit another of the 20 different licenses 😅 |
It's almost all LGPL except for a few libraries that are regular GPL. None of the GPL libraries are things you'd use.
I don't understand why the library optionally being available under a commercial license would be a problem for you? For Tauri everything you'd use is available under the exact same licenses as GTK, The rust bindings being pretty bad is definitely a problem though. |
Sorry, forgot to answer. Just so we're on the same page again, the license is not some kind of blocker, it's just a small additional annoyance, a cherry on top :)
Edit: And yes i know that i said it's a showstopper above, but that was over-exaggerated(?), because of a) the thing mentioned in the "rant" (i just had a similar issue shortly before that) and more importantly b) i misunderstood things about the license model, sorry about that. But tbf that's kindaaa in favor of my argument, since i did look into it and still got stuff mixed up... really having trouble finding the right words here 😅 anyway, moving on...
They are not only pretty bad, they are non-existent for qtwebengine so we'd have to extend existing projects or create something from scratch. And imho it's not worth it at all, if even realistically possible. All that negativity aside, if someone has experience with rust+qt and wants to make this work then feel free to reach out to us! |
That's really the main thing. In a lot of projects pull requests aren't really welcome, so seeing that is a big positive. Hopefully there is someone with experience with the rust-qt ecosystem who will be able to take a look, or maybe the QT bindings will get better in the future. |
To be clear, I am not suggesting to bundle QtWebEngine with Tauri, as it already comes preinstalled on many systems. I am only suggesting to give the possibility to use it instead of Webkit2GTK. |
Doesn't really change much to be honest. The main issue (and by far the biggest one) is making tauri use it. Bundling it inside the appimage (as required by the appimage concept) would be just a somewhat big inconvenience on top.
Also this is not reallyyy true, at least in comparison to webkitgtk, but doesn't matter, even if it would be extremely popular we'd still have to act like nobody has it, just to be sure 🤷 |
But on the top of bundling qtwebengine another funny thing caused by the whole "you need to build the app on the oldest system you want to support" thingy: the appimage version would end up using chromium v56 (or v69 if you reduce your target audience). |
Adding support for QTWebEngine needs a lot of work and time and I think we should invest that into the servo research (Making servo as a webview provider for Tauri on all platforms). |
webkitgtk is slow and lacks many features (such as WebRTC). Using QTWebengine would make Tauri apps on Linux more consistent with their Windows counterparts, and open up the possibility for more apps to use Tauri over Electron.
The text was updated successfully, but these errors were encountered: