On macOS, remove webview from window's NSView before dropping (#754)

tauri-apps · Nov 13, 2022 · 3d3ea80 · 3d3ea80
1 parent 0647c0e
commit 3d3ea80
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.changes/webview-remove.md b/.changes/webview-remove.md
@@ -0,0 +1,5 @@
+---
+"wry": patch
+---
+
+On macOS, remove webview from window's NSView before dropping.
diff --git a/src/webview/wkwebview/mod.rs b/src/webview/wkwebview/mod.rs
@@ -880,6 +880,8 @@ impl Drop for InnerWebView {
         }
       }
 
+      // Remove webview from window's NSView before dropping.
+      let () = msg_send![self.webview, removeFromSuperview];
       let _: Id<_> = Id::from_retained_ptr(self.webview);
       let _: Id<_> = Id::from_retained_ptr(self.manager);
     }