Skip to content

Commit

Permalink
fix: build failing with the tracing feature on Windows (#1192)
Browse files Browse the repository at this point in the history
  • Loading branch information
lucasfernog committed Mar 19, 2024
1 parent 17f3c08 commit 7c9e71f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changes/fix-tracing-build.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wry": patch
---

Fixes compilation failing on Windows with the `tracing` feature enabled.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- uses: Swatinem/rust-cache@v2

- name: build wry
run: cargo build --target ${{ matrix.platform.target }}
run: cargo build --target ${{ matrix.platform.target }} --all-features

- name: build tests and examples
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion src/webview2/drag_drop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ impl DragDropTarget {
tracing::warn!(
"{}",
match _error.code() {
win32f::DV_E_FORMATETC => {
windows::Win32::Foundation::DV_E_FORMATETC => {
// If the dropped item is not a file this error will occur.
// In this case it is OK to return without taking further action.
"Error occurred while processing dropped/hovered item: item is not a file."
Expand Down

0 comments on commit 7c9e71f

Please sign in to comment.