fix empty string bug (fix: #833) (#836)

* fix empty string bug * Push to trigger CI/CD
tauri-apps · Jan 8, 2023 · ceb209e · ceb209e
1 parent ad168a2
commit ceb209e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changes/check-for-empty-init-scripts.md b/.changes/check-for-empty-init-scripts.md
@@ -0,0 +1,5 @@
+---
+"wry": "patch"
+---
+
+Ensures that the script passed to `.with_initialization_script("here")` is not empty.
diff --git a/src/webview/mod.rs b/src/webview/mod.rs
@@ -374,7 +374,9 @@ impl<'a> WebViewBuilder<'a> {
   /// - **Android:** The Android WebView does not provide an API for initialization scripts,
   /// so we prepend them to each HTML head. They are only implemented on custom protocol URLs.
   pub fn with_initialization_script(mut self, js: &str) -> Self {
-    self.webview.initialization_scripts.push(js.to_string());
+    if !js.is_empty() {
+      self.webview.initialization_scripts.push(js.to_string());
+    }
     self
   }