Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples #39

Closed
wusyong opened this issue Feb 17, 2021 · 3 comments
Closed

Add examples #39

wusyong opened this issue Feb 17, 2021 · 3 comments
Labels
good first issue Good for newcomers help wanted Help is requested to fix this issue platform: All type: enhancement

Comments

@wusyong
Copy link
Member

wusyong commented Feb 17, 2021

We want several examples to showcase how wry can do.

This can also help us writing mcve when there's a bug report issue.

PRs are welcome!
@wusyong wusyong added help wanted Help is requested to fix this issue good first issue Good for newcomers type: enhancement platform: All labels Feb 17, 2021
@wusyong
Copy link
Member Author

wusyong commented Feb 20, 2021

We probably also need a README in example directory to demonstrate each example.

@wusyong
Copy link
Member Author

wusyong commented Feb 25, 2021

Custom protocol feature just added! We need an example for it. Feel free to open a creative PR about it!

@wusyong wusyong mentioned this issue Mar 3, 2021
Merged
@jocutajar jocutajar mentioned this issue Mar 24, 2021
Closed
2 tasks
@wusyong
Copy link
Member Author

wusyong commented Apr 1, 2021

Closing it since I believe we have plenty of examples. But feel free to open any PR if anyone wants to add more examples.

@wusyong wusyong closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Help is requested to fix this issue platform: All type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wusyong