fix(windows): properly resolve custom protocol with threaded resolver #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can it be achieved without patch from tao? We have to work with winit as well. |
|
I've implemented the messaging logic manually. Let me know what you think @wusyong @amrbashir |
amrbashir
previously approved these changes
Sep 11, 2023
amrbashir
approved these changes
Sep 11, 2023
lucasfernog
added a commit
that referenced
this pull request
Sep 11, 2023
…#1023) * fix(windows): properly resolve custom protocol with threaded resolver * revert example * implement messaging manually * reuse the existing window procedure * fix change file [skip ci] --------- Co-authored-by: amrbashir <amr.bashir2015@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
Other information
Needs tauri-apps/tao#792