Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cfg_aliases for easier feature configuration #1077

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Add cfg_aliases for easier feature configuration #1077

merged 4 commits into from
Nov 17, 2023

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Nov 13, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@wusyong wusyong marked this pull request as ready for review November 13, 2023 07:09
@wusyong wusyong requested a review from a team as a code owner November 13, 2023 07:09
pewsheen
pewsheen previously approved these changes Nov 13, 2023
src/lib.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
objc-exception = ["objc/exception"]
file-drop = []
protocol = []
devtools = []
transparent = []
fullscreen = []
linux-body = ["webkit2gtk/v2_40"]
linux-body = ["webkit2gtk/v2_40", "os-webview"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename this one to webkit2gtk-body now that we are preparing for other implementations?

if we rename it here, we need to rename in code too

@wusyong wusyong merged commit 15ae3c7 into dev Nov 17, 2023
11 checks passed
@wusyong wusyong deleted the cfg_alias branch November 17, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants