Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async multiwindow deadlock #382

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Fix async multiwindow deadlock #382

merged 2 commits into from
Aug 17, 2021

Conversation

chippers
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This is triggered only when the queue is flushed while being empty. Due to how the mutli_window example is constructed, the flushing can happen twice before the second webview is queued.

@chippers chippers requested a review from a team as a code owner August 17, 2021 04:47
@chippers chippers requested a review from a team August 17, 2021 04:47
wusyong
wusyong previously approved these changes Aug 17, 2021
@wusyong wusyong merged commit 5377821 into dev Aug 17, 2021
@wusyong wusyong deleted the fix/async-multiwindow branch August 17, 2021 05:05
@github-actions github-actions bot mentioned this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants