Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Custom protcol request/response #387

Merged
merged 18 commits into from
Aug 22, 2021
Merged

Conversation

lemarier
Copy link
Member

@lemarier lemarier commented Aug 19, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Todo:

  • Windows Request method
  • Linux

Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier
Copy link
Member Author

lemarier commented Aug 19, 2021

Linux seems to have a blocker;
tauri-apps/webkit2gtk-rs#61

@wusyong would be great if you can take a look!

Thanks

**

We need to be able to;

  • Read all the headers on the request
  • Write all needed headers on the responses and send a custom status code

Signed-off-by: David Lemarier <david@lemarier.ca>
src/shared/http/request.rs Outdated Show resolved Hide resolved
@wusyong
Copy link
Member

wusyong commented Aug 20, 2021

@lemarier soup-rs is a bit outdated. I'll see if I could publish our own.

examples/html.rs Outdated Show resolved Hide resolved
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier lemarier marked this pull request as ready for review August 20, 2021 18:33
@lemarier lemarier requested a review from a team as a code owner August 20, 2021 18:33
@lemarier lemarier requested review from a team August 20, 2021 18:33
Signed-off-by: David Lemarier <david@lemarier.ca>
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wusyong wusyong merged commit d202573 into dev Aug 22, 2021
@wusyong wusyong deleted the feat/refactor-protocol branch August 22, 2021 07:28
@github-actions github-actions bot mentioned this pull request Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants