WebView2: Enable/disable platform default zooming shortcuts, closes #569 #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but only on Windows (WebView2)
amrbashir
requested changes
May 5, 2022
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
JensMertelmeyer
force-pushed
the
allowZooming
branch
from
13e3159
to
a3087b9
Compare
amrbashir
approved these changes
May 15, 2022
Merged
|
I'm new to tauri; was this feature successfully added and if so how can i enable the zoom shortcuts for my App? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
By default, platform default zoom is disabled. This will also disable zooming by trackpad or touchscreen which was previously not the case.
Checklist
fix: remove a typo, closes #___, #___)Other information
I absolutely agree with wry's approach to have default zooming disabled by default. However, I think there are many valid use cases where it makes sense to have the option to enable it.
Thank you for considering.