Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set system language to webview on windows, closes #442 #640

Merged
merged 2 commits into from Jul 25, 2022
Merged

fix: set system language to webview on windows, closes #442 #640

merged 2 commits into from Jul 25, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Jul 25, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • [n] No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Currently this is not working on ARM windows but this is doing on x86 windows.

@keiya01 keiya01 requested a review from a team as a code owner July 25, 2022 14:49
@keiya01 keiya01 self-assigned this Jul 25, 2022
amrbashir
amrbashir requested changes Jul 25, 2022
View reviewed changes
.changes/i18n-windows.md Outdated Show resolved Hide resolved
@amrbashir amrbashir merged commit e9f04d7 into dev Jul 25, 2022
@amrbashir amrbashir deleted the feat/i18n-windows branch July 25, 2022 15:41
@github-actions github-actions bot mentioned this pull request Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees

@keiya01 keiya01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keiya01 @amrbashir