Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): JNI execution handle #689

Merged
merged 2 commits into from Sep 7, 2022
Merged

feat(android): JNI execution handle #689

merged 2 commits into from Sep 7, 2022

Conversation

jhutchins
Copy link
Contributor

@jhutchins jhutchins commented Sep 6, 2022 •
edited

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Add the ability to execute JNI commands on the webview object.

@jhutchins jhutchins requested a review from a team as a code owner September 6, 2022 18:07
@jhutchins jhutchins mentioned this pull request Sep 6, 2022
Merged
6 tasks
amrbashir
amrbashir requested changes Sep 6, 2022
View reviewed changes
src/webview/mod.rs Show resolved Hide resolved
amrbashir
amrbashir previously approved these changes Sep 6, 2022
View reviewed changes
lucasfernog
lucasfernog previously approved these changes Sep 6, 2022
View reviewed changes
@amrbashir amrbashir dismissed stale reviews from lucasfernog and themself via ddea65f September 7, 2022 12:08
@amrbashir amrbashir merged commit 2bfc6c3 into tauri-apps:dev Sep 7, 2022
@github-actions github-actions bot mentioned this pull request Sep 7, 2022
Merged
@jhutchins jhutchins deleted the feat/webview-access branch September 7, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

@lucasfernog lucasfernog lucasfernog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhutchins @lucasfernog @amrbashir