Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): Focus webview when window starts moving or resizing. #695

Merged
merged 7 commits into from Sep 16, 2022
Merged

fix(windows): Focus webview when window starts moving or resizing. #695

merged 7 commits into from Sep 16, 2022

Conversation

FabianLars
Copy link
Member

@FabianLars FabianLars commented Sep 16, 2022 •
edited

Fixes tauri-apps/tauri#1911 (comment), tauri-apps/tauri#5135

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

@FabianLars FabianLars requested a review from a team as a code owner September 16, 2022 18:47
@FabianLars FabianLars linked an issue Sep 16, 2022 that may be closed by this pull request
[bug] The drop-down menu of "select" item does not change the position as the application window moves tauri-apps/tauri#5135
Closed
@FabianLars
Copy link
Member Author

btw this is basically how the chrome browser behaves, with the difference that chrome actually blurs the select element while it will still look focused (minus the open dropdown) in wv2.

amrbashir
amrbashir requested changes Sep 16, 2022
View reviewed changes
src/webview/webview2/mod.rs Outdated Show resolved Hide resolved
@FabianLars FabianLars closed this Sep 16, 2022
@FabianLars FabianLars deleted the fix/win-focus branch September 16, 2022 19:59
@FabianLars FabianLars restored the fix/win-focus branch September 16, 2022 20:14
@FabianLars
Copy link
Member Author

shit i was a little too trigger happy here. i think i got it

@FabianLars FabianLars reopened this Sep 16, 2022
amrbashir
amrbashir previously approved these changes Sep 16, 2022
View reviewed changes
amrbashir
amrbashir previously approved these changes Sep 16, 2022
View reviewed changes
@amrbashir amrbashir merged commit a1001dd into dev Sep 16, 2022
@amrbashir amrbashir deleted the fix/win-focus branch September 16, 2022 21:31
@github-actions github-actions bot mentioned this pull request Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@FabianLars @amrbashir