feat: add .url()to access the current url
#732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
requested changes
Oct 25, 2022
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
approved these changes
Oct 25, 2022
amrbashir
requested changes
Oct 25, 2022
amrbashir
approved these changes
Oct 25, 2022
Merged
dklassic
pushed a commit
that referenced
this pull request
Apr 12, 2023
* feat: add `.url()`to access the current url * fmt * add url import * fix linux and windows * add stub to android webview * Update src/webview/webview2/mod.rs Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com> * Add android * change file and doc Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com> # Conflicts: # src/webview/android/main_pipe.rs # src/webview/android/mod.rs # src/webview/webkitgtk/mod.rs
dklassic
pushed a commit
that referenced
this pull request
Apr 12, 2023
* feat: add `.url()`to access the current url * fmt * add url import * fix linux and windows * add stub to android webview * Update src/webview/webview2/mod.rs Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com> * Add android * change file and doc Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
wusyong
pushed a commit
that referenced
this pull request
Apr 12, 2023
* feat: add `WebView::url()` to access the current url (#732) * feat: add `.url()`to access the current url * fmt * add url import * fix linux and windows * add stub to android webview * Update src/webview/webview2/mod.rs Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com> * Add android * change file and doc Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com> * Changed wry to patch --------- Co-authored-by: Jonas Kruckenberg <iterpre@protonmail.com> Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
wusyong
added a commit
that referenced
this pull request
Apr 12, 2023
* feat: add `WebView::url()` to access the current url (#732) * feat: add `.url()`to access the current url * fmt * add url import * fix linux and windows * add stub to android webview * Update src/webview/webview2/mod.rs Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com> * Add android * change file and doc Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com> # Conflicts: # src/webview/android/main_pipe.rs # src/webview/android/mod.rs # src/webview/webkitgtk/mod.rs * Changed wry to patch * Update mod.rs * fixed compile error and removed redundant file * Remove MainPipe from src/webview/android/mod.rs Co-authored-by: Ngo Iok Ui (Wu Yu Wei) <yuweiwu@pm.me> * Include required parameter RGBA in src/webview/webkitgtk/mod.rs Co-authored-by: Ngo Iok Ui (Wu Yu Wei) <yuweiwu@pm.me> --------- Co-authored-by: Jonas Kruckenberg <iterpre@protonmail.com> Co-authored-by: Ngo Iok Ui (Wu Yu Wei) <yuweiwu@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information