Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wkwebview): make webview first responder, closes #739 #740

Merged
merged 1 commit into from Oct 28, 2022

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Oct 27, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

I confirmed #739 was solved on my local machine (macOS 11).

Just after launching the application window, typing some keys is reflected:

screenshot

@rhysd rhysd requested a review from a team as a code owner October 27, 2022 12:55
@rhysd
Copy link
Contributor Author

rhysd commented Oct 27, 2022

I forgot committing a .changes file. I amended and force-pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants