Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On macOS, add WKWebview as subview of existing NSView directly #745

Merged
merged 1 commit into from Nov 7, 2022
Merged

On macOS, add WKWebview as subview of existing NSView directly #745

merged 1 commit into from Nov 7, 2022

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Nov 6, 2022 •
edited

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@wusyong wusyong requested a review from a team as a code owner November 6, 2022 12:17
@wusyong wusyong merged commit 008eca8 into dev Nov 7, 2022
@wusyong wusyong deleted the ns-view branch November 7, 2022 10:26
@github-actions github-actions bot mentioned this pull request Nov 7, 2022
Merged
@rhysd rhysd mentioned this pull request Nov 8, 2022
Closed
2 tasks
grant0417 added a commit to grant0417/wry that referenced this pull request Nov 11, 2022
@grant0417
Revert "On macOS, add WKWebview as subview of existing NSView directly (
eabced8 
tauri-apps#745)"

This reverts commit 008eca8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wusyong @amrbashir