Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On macOS, fix keyinput missing by calling super class methods #764

Merged
merged 1 commit into from Nov 21, 2022
Merged

On macOS, fix keyinput missing by calling super class methods #764

merged 1 commit into from Nov 21, 2022

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Nov 21, 2022 •
edited

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

fix tauri-apps/tauri#5662
截圖 2022-11-21 下午9 28 44

@wusyong wusyong requested a review from a team as a code owner November 21, 2022 13:24
@wusyong
Copy link
Member Author

wusyong commented Nov 21, 2022 •
edited

cc @FabianLars
I've checked:

FabianLars
FabianLars approved these changes Nov 21, 2022
View reviewed changes
Copy link
Sponsor Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in the name of our testers on discord 😄

@wusyong wusyong merged commit e40e55a into dev Nov 21, 2022
@wusyong wusyong deleted the fix-key branch November 21, 2022 14:26
@github-actions github-actions bot mentioned this pull request Nov 21, 2022
Merged
@amrbashir amrbashir mentioned this pull request Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Keyboard inputs not working on Mac unless modifier keys (shift, ctrl, alt, etc.) are pressed
3 participants
@wusyong @lucasfernog @FabianLars