Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): fix unresolved reference in kotlin files #932

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix(android): fix unresolved reference in kotlin files #932

merged 1 commit into from
Apr 19, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Apr 18, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@amrbashir amrbashir requested a review from a team as a code owner April 18, 2023 18:55
@wusyong wusyong merged commit ed36c0b into dev Apr 19, 2023
@wusyong wusyong deleted the fix/android/unresolved branch April 19, 2023 05:05
@github-actions github-actions bot mentioned this pull request Apr 19, 2023
Merged
amrbashir added a commit that referenced this pull request Apr 19, 2023
@amrbashir
fix(android): use getContext getter instead of direct access
f8c53e9 
continuation of #932
@amrbashir amrbashir mentioned this pull request Apr 19, 2023
Merged
13 tasks
wusyong pushed a commit that referenced this pull request Apr 20, 2023
@amrbashir
fix(android): use getContext getter instead of direct access (#934)
4e2b43a 
continuation of #932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @wusyong