New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type convert boolean variables correctly (closes #149) #150
Type convert boolean variables correctly (closes #149) #150
Conversation
Rather than using a custom constructor it is probably better to use strtobool from the standard library, which can handle a lot more than just Other than that, this all looks good! |
Happy to use See the new commit for changes:
|
There is a long running known issue with combining I have added |
Thanks for that, it should be deployed in version 0.15.1. |
@michaelboulton PyPI latest version appears to be 0.14.4 - have had a quick look at the Travis logs and can't see any obvious errors |
It seems like the deplyment via travis isn't actually deploying - I don't have time to look at this until monday though unfortunately, I might just change it so it's using gitlab CI to do the deployment |
See #149 for issue details.
This PR:
!bool
type conversion is incorrect!bool
using a custombool
constructor classThe custom bool constructor is similar to the builtin
bool
constructor as per PEP 285, and as discussed here