Update docs with cookie information #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhowes
reviewed
Feb 12, 2018
| [requests](http://docs.python-requests.org/en/master/api/#requests.request) | ||
| under the hood, and uses a persistent `Session` for each test. This means that | ||
| cookies are propagated forward to further stages of a test. Cookies can also be | ||
| required to pass a test. For example, say we have a server that returns a cookie |
There was a problem hiding this comment.
Mention where the source for this test is?
There was a problem hiding this comment.
Which source? This is just an example of a server that would behave like that
There was a problem hiding this comment.
That is just an example implementation of the server in python - it doesn't really relate to the documentation. There aren't implementations for any of the other examples
benhowes
reviewed
Feb 12, 2018
| ``` | ||
|
|
||
| This test ensures that a cookie called `session-cookie` is returned from the | ||
| 'login' stage, and this cookie will be sent with all future stages of that test. |
There was a problem hiding this comment.
Is the term test well defined in the document?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taverntesting/tavern#28