Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /File Import line length limit. #92

Closed
taviso opened this issue Jun 16, 2022 · 1 comment
Closed

Remove /File Import line length limit. #92

taviso opened this issue Jun 16, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@taviso
Copy link
Owner

taviso commented Jun 16, 2022

There is a line-length limit of 512 characters for /File Import. I think this is from fm_file_import(), I see no reason we can't just remove that limit, or at least make it really big.

@taviso
Copy link
Owner Author

taviso commented Jun 25, 2022

I have a patch that fixes this, but I want to write some tests to make sure it works reliably.

It seems like the longest possible line you could ever want to import would be 512*256 = 132k (the longest possible label is 512 bytes, and there are 256 columns), but that seems ridiculously big. The current longest possible import line is 1024, which seems equally ridiculously, but too small.

Let's go for 4096 for now, and I'll increase it if anyone complains.

@taviso taviso closed this as completed in e786e56 Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant