Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap doesn't work on windows phone #104

Closed
luisrudge opened this issue Nov 19, 2014 · 19 comments
Closed

tap doesn't work on windows phone #104

luisrudge opened this issue Nov 19, 2014 · 19 comments

Comments

@luisrudge
Copy link

hi. great lib! everything worked on windows phone, except by tap and double tap. i'm not sure if it's something with the demo or the lib, but the demo page is not working.

@kenrick95
Copy link

I tried this out on IE11 of my Surface RT and the same issue happened. Apparently if I tapped repeatedly fast enough using 2 fingers, the event will be triggered and the effect will run as expected.

@taye
Copy link
Owner

taye commented Nov 19, 2014

I think the problem might be that there's a pointermove is fired before the touch ends. Increasing the pointerMoveTolerance might help.

interact.pointerMoveTolerance(5);

Unfontunately, I don't have a Windows Phone/RT thing to test with.

@luisrudge
Copy link
Author

I can test it! Can you update the main site?

@taye
Copy link
Owner

taye commented Nov 21, 2014

Actually, I think I'll add a slider to this demo so that you can adjust the tolerance on your phone.

@lypanov
Copy link

lypanov commented Nov 21, 2014

Doesn't work in Windows 8 "Metro" IE 11 on a touch screen enabled device. @taye The above demo link doesn't do much at all in IE11. Doing a medium distance drag to the right results in IE 11 giving the the "back button" behaviour signal. Maybe you want to use http://msdn.microsoft.com/en-us/library/ie/hh772044(v=vs.85).aspx ?

@taye
Copy link
Owner

taye commented Nov 21, 2014

@luisrudge There were a few hiccups but that demo should now be updated and working correctly.

@lypanov There was a small bug that broke touch input. It should work now.

@luisrudge
Copy link
Author

This demo doesn't do anything on windows phone :B

@taye
Copy link
Owner

taye commented Nov 22, 2014

@lypanov you were right. I thought I had already done it but I was thinking of user-select: none.
@luisrudge It should do something now :>

@luisrudge
Copy link
Author

Great! Now it gets a bunc of events (touch up/down, swipe up/down/left/right), but it don't get tap or double tap

@taye
Copy link
Owner

taye commented Nov 22, 2014

Okay I'm almost certain that I got it this time :P. Thanks for bearing with me.

@taye
Copy link
Owner

taye commented Nov 22, 2014

cc14819 should have fixed it now.

@luisrudge
Copy link
Author

ohhhhhhhh yes :) it's working! THANKS!

@taye
Copy link
Owner

taye commented Nov 22, 2014

Cool. For future reference, what's the minimum tolerance that seems to work consistently?

@luisrudge
Copy link
Author

everything worked with 1

@taye
Copy link
Owner

taye commented Nov 22, 2014

Brilliant. Thank you!

@kenrick95, @lypanov could you confirm whether it works for you as well?

@kenrick95
Copy link

Well, interactjs.io behaves the same (not working for tap and double tap), although it's working on any value of tolerance at the demo.

@taye
Copy link
Owner

taye commented Nov 22, 2014

I haven't updated the homepage. However, I've just added some stuff to allow testing the homepage with different versions of interact.js using a debug=[<user>/]<git revision> query parameter. For example:

http://interactjs.io/?debug=cc148197a0
http://interactjs.io/?debug=taye/master

It'll load the specified version from rawgit.com.

@lypanov
Copy link

lypanov commented Nov 22, 2014

Works flawlessly on my windows phone now. Excellent work!

Sent from my Windows Phone


From: Taye Amailto:notifications@github.com
Sent: ‎22-‎11-‎2014 13:52
To: taye/interact.jsmailto:interact.js@noreply.github.com
Cc: Alexander Kellettmailto:lypanov@outlook.com
Subject: Re: [interact.js] tap doesn't work on windows phone (#104)

I haven't updated the homepage. However, I've just added some stuff to allow testing the homepage with different versions of interact.js using a debug=[<user>/]<git revision> query parameter. For example:

http://interactjs.io/?debug=cc148197a0
http://interactjs.io/?debug=taye/master

It'll load the specified version from rawgit.com.


Reply to this email directly or view it on GitHub:
#104 (comment)

@taye taye closed this as completed Nov 24, 2014
@taye
Copy link
Owner

taye commented Nov 30, 2014

v1.1.3 is out. I should really have left this issue open until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants