Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'webkitMovementX' is deprecated. Please use 'movementX' instead. #277

Closed
lookfirst opened this issue Sep 5, 2015 · 12 comments
Closed

'webkitMovementX' is deprecated. Please use 'movementX' instead. #277

lookfirst opened this issue Sep 5, 2015 · 12 comments

Comments

@lookfirst
Copy link

Seeing this in Chrome 45.0.2454.85 (64-bit) dev tools console.

@taye
Copy link
Owner

taye commented Sep 6, 2015

All the properties of events are copied for interact.js' move, tap, hold, etc. event objects including deprecated properties. You can safely ignore that warning.

@taye taye closed this as completed Sep 6, 2015
@lookfirst
Copy link
Author

@taye Lame. I don't want to see that in my dev tools console.

@baptistebriel
Copy link

@lookfirst you could edit the extend function

function extend (dest, source) {

function extend (dest, source) {
  for (var prop in source) {
      dest[prop] = source[prop];
  }
  return dest;
}
function extend (dest, source) {
  for (var prop in source) {
      if(prop != 'webkitMovementY' && prop != 'webkitMovementX')
        dest[prop] = source[prop];
  }
  return dest;
}

@lookfirst
Copy link
Author

@baptistebriel Perfect... submit a PR. =)

@lookfirst
Copy link
Author

@taye How many duplicate issues will you close before fixing this?

taye added a commit that referenced this issue Sep 8, 2015
@taye
Copy link
Owner

taye commented Sep 8, 2015

@lookfirst

Perfect... submit a PR. =)

That solution was far from perfect.

How many duplicate issues will you close before fixing this?

You would have done better to give me reasons to prevent those warnings from showing up. You didn't write anything before that clearly meant that you were looking for a change in interact.js to remove the warnings.

@lookfirst
Copy link
Author

@taye Thanks for fixing things.

@taye
Copy link
Owner

taye commented Sep 8, 2015

You're welcome :)

@lookfirst
Copy link
Author

@taye New release time? =)

@taye
Copy link
Owner

taye commented Sep 8, 2015

Very soon, probably before the end of the week. And this time I mean it.

@lookfirst
Copy link
Author

#releaseearlyreleaseoften

@taye
Copy link
Owner

taye commented Sep 8, 2015

There aren't proper tests though so I didn't have the confidence to release and I was too busy to deal with potential bug reports. I'm working on the testing problem but it's a lot of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants