Bugfix for calling unset method on an Interactable #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three bug fixes for cleaning up listeners:
1. Call 'var myInteractable = interact(myElem)' --> the Interactable constructor will call 'events.add(this._element, ...)'
The unset method -- 'myInteractable.unset()' -- should be calling 'events.remove(this._element, 'all')' to remove those event handlers
2. The 'remove' method should only remove 1 element when calling splice instead of all elements after the specified index.
3. On top of taye#2, the 'remove' method should return after looping through the 'all' listener condition so that the arrays are only spliced one time instead of twice (once after removing the specific handler and once after the 'all' loop finishes)
Bug Fix for removing listeners
taye
added a commit
that referenced
this pull request
May 5, 2015
Bugfix for calling unset method on an Interactable
|
Very much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some debugging today to find out that my event handlers are still holding references to my DOM elements after calling 'unset'. These changes seem to correct the issue. Please let me know what you think!