Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 10-Colocating_Selectors_with_Reducers.md #19

Merged
merged 1 commit into from Aug 16, 2017

Conversation

janzheng
Copy link
Contributor

const mapStateToProps = (state, { params }) => ({
      todos: getVisibleTodos(state, params.filter || 'all' )
  });

was the entire reason we had this section, and somehow this key point was left out of the notes. Without this part the code won't work, since formerly state.todos is now just state in the getVisibleTodos function call

```
const mapStateToProps = (state, { params }) => ({
      todos: getVisibleTodos(state, params.filter || 'all' )
  });

```

was the entire reason we had this section, and somehow this key point was left out of the notes. Without this part the code won't work, since formerly `state.todos` is now just `state` in the getVisibleTodos function call
Copy link
Owner

@tayiorbeii tayiorbeii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tayiorbeii tayiorbeii merged commit 73711ab into tayiorbeii:master Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants