Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginate option returns result with symbolized keys #46

Open
shved opened this issue Feb 9, 2018 · 3 comments
Open

Paginate option returns result with symbolized keys #46

shved opened this issue Feb 9, 2018 · 3 comments

Comments

@shved
Copy link
Contributor

shved commented Feb 9, 2018

Because of this line
https://github.com/taylorbrooks/closeio/blob/master/lib/closeio/client.rb#L68
result returned from paginate: true call will have symbolic keys, rather than strings. It leads to "undefined method for NilClass" kind of exceptions.

My proposal is to stringify keys explicitly to keep common response structure
@shved
Copy link
Contributor Author

shved commented Feb 9, 2018 •
edited

@taylorbrooks review and merge please
here is PR #47

@shved
Copy link
Contributor Author

shved commented Dec 1, 2018

I've closed the PR since I'm not going to finish the work. Fix this anyway someone guys It's quiet easy! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shved and others