Add literal support for formatting masks #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for creating the pull request. Just a couple of changes. |
| //Make literals inactive by replacing them with _ | ||
| mask = mask.replace(literal, function($0, $1) { | ||
| literals.push($1); | ||
| return '_'; |
There was a problem hiding this comment.
Can we use something more unlikely to be used? Someone may put a _ and break this. How about ??
There was a problem hiding this comment.
Good point, will update _ to ??
- Use another placeholder when handling literals - Format comments - Update package version to the original version
|
Ported tests from moment https://github.com/moment/moment/blob/develop/src/test/moment/format.js#L12 except for the ones that deal with localized tokens. One of the ported tests revealed an issue with processing literals that span multiple lines, fixed it. |
|
This is great. I really appreciate you doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to be able to use literals in formatting masks, for example
moment.js includes support for literals as well http://stackoverflow.com/questions/28241002/moment-js-include-text-in-middle-of-date-format
This PR adds support for literals in formatting masks, updates README to include an example of literal usage and increases the minor version number.