Reduce size of NPM package #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorrit Thanks for doing this. I would like to keep the LICENSE file in the package. I don't think the tests are necessary. Can you update the pull request to add the LICENSE? |
|
The README and LICENSE files will be included by npm even if they're not specified in the |
|
Great. Thanks. I will push out a new version later today |
|
Thank you for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NPM package contains a lot of files that are not needed to use fecha. This change reduces the package to just the source and minified files. The README and LICENSE files are always included, by the way.
The files that are currently in the package are:
My preference is to not include tests, but if you want to keep them in the NPM package I'll update the PR.