Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle unresolved promises in training script #12

Closed
taylorhansen opened this issue Feb 19, 2019 · 2 comments
Closed

Properly handle unresolved promises in training script #12

taylorhansen opened this issue Feb 19, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@taylorhansen
Copy link
Owner

taylorhansen commented Feb 19, 2019

If something happens where both sides of the Battle have not sent any messages to the BattleStream and are instead waiting to read from it, this causes the Promise.all statement in the play() function to never resolve, causing an immediate termination of the process. Either figure out a way to detect and handle this, or just cover all corner cases where this may happen. Doing both would be preferable here.

@taylorhansen taylorhansen added the bug Something isn't working label Mar 22, 2019
@taylorhansen taylorhansen added the help wanted Extra attention is needed label May 4, 2019
@taylorhansen
Copy link
Owner Author

This looks promising.

@taylorhansen taylorhansen removed the help wanted Extra attention is needed label Feb 13, 2020
taylorhansen added a commit that referenced this issue Feb 22, 2020
@taylorhansen
Copy link
Owner Author

After looking at some of the recent training script changes, I think this is resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant