Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_package(args REQUIRED) doesn't set args_VERSION #109

Closed
yurivict opened this issue Dec 29, 2022 · 3 comments
Closed

find_package(args REQUIRED) doesn't set args_VERSION #109

yurivict opened this issue Dec 29, 2022 · 3 comments
Assignees

Comments

@yurivict
Copy link

It's common for cmake-discovered packages to set the {name}_VERSION variable.

@Taywee
Copy link
Owner

Taywee commented Dec 29, 2022

Yeah, that's definitely an issue here. When packaging and pulling in args, I get these variables:

-- args_FOUND=1
-- args_VERSION_COUNT=0
-- args_VERSION_MAJOR=0
-- args_VERSION_MINOR=0
-- args_VERSION_PATCH=0
-- args_VERSION_TWEAK=0

This is supposed to be set via find_package. Honestly, I'm not exactly sure how I'm supposed to fix this. CMake is not fun to work with. I'll do some digging and see if I can find something, but I'd be more than happy to accept a pull request that addresses it too.

@Taywee
Copy link
Owner

Taywee commented Dec 29, 2022

Figured it out. This is solved in version 6.4.3.

-- args_FOUND=1
-- args_VERSION=6.4.3
-- args_VERSION_COUNT=3
-- args_VERSION_MAJOR=6
-- args_VERSION_MINOR=4
-- args_VERSION_PATCH=3
-- args_VERSION_TWEAK=0

@Taywee
Copy link
Owner

Taywee commented Dec 29, 2022

The version is now released. Thank you for the report. I'm certain the CMakeLists.txt still has tons of problems, but it's hard to be motivated to work on it when it's still CMake in the end.

@Taywee Taywee closed this as completed Dec 29, 2022
@Taywee Taywee self-assigned this Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants