Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to angular 8 and cli #216

Closed
wants to merge 2 commits into from
Closed

feat: upgrade to angular 8 and cli #216

wants to merge 2 commits into from

Conversation

mattlewis92
Copy link
Collaborator

Migrates to the latest angular version and uses the CLI to do all the build tooling.

BREAKING CHANGE: angular 8 or higher is now required to use this library

This should enable full compatibility with ivy, currently it fails with:

ERROR in node_modules/ng2-nouislider/ng2-nouislider.module.d.ts(1,22): error TS-996002: Appears in the NgModule.imports of TestModule, but could not be resolved to an NgModule class

because of the older build tooling.

I'm also thinking it would be a good time to rename the package to ngx-nouislider, I've reached out to the person who currently has the package name to try and get access.

Try it today with:

npm i ng2-nouislider@next

BREAKING CHANGE: angular 8 or higher is now required to use this library
@mattlewis92 mattlewis92 requested a review from tb June 1, 2019 19:33
@tb
Copy link
Owner

tb commented Jun 3, 2019

Great work @mattlewis92 with ivy compatibility!

PR is now only dependant on the npm package name change.

@meness
Copy link

meness commented Jun 7, 2019

Nice work! When this would be merged?

@mattlewis92
Copy link
Collaborator Author

@meness I'm just waiting on getting the new package name. but you can try it today with:

npm i ng2-nouislider@next

@alejandrocoding
Copy link

Thanks @mattlewis92 I will be using @next now, any update on the package rename?

@mattlewis92
Copy link
Collaborator Author

No update yet, I've pinged the maintainer again for an update, but if I don't hear anything back then I'll just release this on the existing package name and maybe in the future we can rename to something else.

@LiorSaadon
Copy link

anything new with the maintainer? when will this will be official ? @tb Tomasz Bak

@mattlewis92
Copy link
Collaborator Author

Nope I didn't hear anything back, I'll just release it under the original package name for now, we can always move it over later in another release.

FYI there's no real urgency for this now, as the ivy compat issues have been fixed on the angular side, so the only change will just be requiring angular 8 or above

@Carlesgg97
Copy link

any news? this project seems to be absolutely dead.

@kbrilla
Copy link

kbrilla commented Nov 26, 2021

hey, @mattlewis92 with angular 13, I would be willing to update this project to v13 maybe - to go with angular versioning schema and go with full compilation maybe or at least partial but in new lib format of Angular 13 to get rid of ngcc compilation on this lib?

From Angular 13:

Processing legacy "View Engine" libraries:
Encourage the library authors to publish an Ivy distribution.

@mattlewis92
Copy link
Collaborator Author

hey, @mattlewis92 with angular 13, I would be willing to update this project to v13 maybe - to go with angular versioning schema and go with full compilation maybe or at least partial but in new lib format of Angular 13 to get rid of ngcc compilation on this lib?

That sounds great, yes please! Not sure if it's easiest to branch off this PR and upgrade with ng update for each major version, or just start with a fresh angular CLI library and copy the files over.

@mattlewis92
Copy link
Collaborator Author

Closing in favor of #241 (this was finally released to npm as 2.0.0 stable!!)

@mattlewis92 mattlewis92 closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants