-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to angular 8 and cli #216
Conversation
BREAKING CHANGE: angular 8 or higher is now required to use this library
Great work @mattlewis92 with ivy compatibility! PR is now only dependant on the npm package name change. |
Nice work! When this would be merged? |
@meness I'm just waiting on getting the new package name. but you can try it today with:
|
Thanks @mattlewis92 I will be using @next now, any update on the package rename? |
No update yet, I've pinged the maintainer again for an update, but if I don't hear anything back then I'll just release this on the existing package name and maybe in the future we can rename to something else. |
anything new with the maintainer? when will this will be official ? @tb Tomasz Bak |
Nope I didn't hear anything back, I'll just release it under the original package name for now, we can always move it over later in another release. FYI there's no real urgency for this now, as the ivy compat issues have been fixed on the angular side, so the only change will just be requiring angular 8 or above |
any news? this project seems to be absolutely dead. |
hey, @mattlewis92 with angular 13, I would be willing to update this project to v13 maybe - to go with angular versioning schema and go with full compilation maybe or at least partial but in new lib format of Angular 13 to get rid of ngcc compilation on this lib? From Angular 13: Processing legacy "View Engine" libraries: |
That sounds great, yes please! Not sure if it's easiest to branch off this PR and upgrade with |
Closing in favor of #241 (this was finally released to npm as 2.0.0 stable!!) |
Migrates to the latest angular version and uses the CLI to do all the build tooling.
BREAKING CHANGE: angular 8 or higher is now required to use this library
This should enable full compatibility with ivy, currently it fails with:
because of the older build tooling.
I'm also thinking it would be a good time to rename the package to
ngx-nouislider
, I've reached out to the person who currently has the package name to try and get access.Try it today with: