Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions are not requested by pages()/reduce() #183

Merged
merged 2 commits into from
May 8, 2024

Conversation

tb1337
Copy link
Owner

@tb1337 tb1337 commented May 8, 2024

pypaperless didn't request object permissions when using the IterableMixin, as it did when using the CallableMixin.

Solves #161.

@tb1337 tb1337 self-assigned this May 8, 2024
@tb1337 tb1337 added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label May 8, 2024
@tb1337 tb1337 linked an issue May 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (4e0880d) to head (d903065).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files          34       34           
  Lines        1460     1461    +1     
  Branches      190      191    +1     
=======================================
+ Hits         1433     1434    +1     
  Misses         13       13           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 8, 2024

@tb1337 tb1337 merged commit 54022e0 into main May 8, 2024
14 checks passed
@tb1337 tb1337 deleted the 161-fix-requesting-permissions branch May 8, 2024 07:06
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting permissions with reduce not working
1 participant