Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined index heading_text when saving run sheet #341

Closed
tbar0970 opened this issue Mar 9, 2017 · 5 comments
Closed

Undefined index heading_text when saving run sheet #341

tbar0970 opened this issue Mar 9, 2017 · 5 comments

Comments

@tbar0970
Copy link
Owner

tbar0970 commented Mar 9, 2017

111

Undefined index: heading_text
Line 58 of /home/jethro/code/2.18.3-RC4/views/view_8_services.class.php

REFERER: https://xyz.easyjethro.com.au/?view=services&date=2017-03-12&congregationid=6&editing=1
USER_AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/602.4.8 (KHTML, like Gecko) Version/10.0.3 Safari/602.4.8

REQUEST:
Array
(
[view] => services
[date] => 2017-03-12
[congregationid] => 6
[editing] => 1
[save_service] => 1
[title] => Array
(
...
)

[componentid] => Array
(
...
)

[length_mins] => Array
(
...
)

[show_in_handout] => Array
(
...
)

[note] => Array
(
...
)

[personnel] => Array
(
...
)

[service_comments] =>
)

BACKTRACE:
Array
(
[0] => Array
(
[file] => /home/jethro/code/2.18.3-RC4/include/system_controller.class.php
[line] => 127
[function] => processView
[class] => View_services
[type] => ->
[args] => Array
(
)

   )

[1] => Array
(
[file] => /home/jethro/code/2.18.3-RC4/index.php
[line] => 58
[function] => run
[class] => System_Controller
[type] => ->
[args] => Array
(
)

   )

)

@tbar0970
Copy link
Owner Author

tbar0970 commented May 6, 2017

+1 - safari again

@tbar0970
Copy link
Owner Author

I got this just now, after I edited a run sheet and the only change I made was editing the service comments... could that be it?

@tbar0970
Copy link
Owner Author

tbar0970 commented Aug 4, 2020

Doesnt seem to be

tbar0970 added a commit that referenced this issue Jun 20, 2023
…unction from being called. (b) This might also address whatever circumstances are causing #341
@tbar0970
Copy link
Owner Author

I experienced an issue like this one today, in the context of a bug that was preventing JethroServicePlanner.onsubmit to run before the form submitted. The heading_text elements are added in to the request by this function.
So I suspect the original errors are some similar situation, where the form is 'natively' submitting without the onSubmit function running.

tbar0970 added a commit that referenced this issue Jun 20, 2023
…er the form is submitted, regardless of what triggers the submit
@tbar0970
Copy link
Owner Author

Despite not having tracked down the original trigger, I'm fairly confident this change will make this one go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant