iCal URLs only work if the public section is enabled

[jefft]

In the members section, it's possible for users to 'Subscribe' to their roster:

This generates an iCal link:

However if the 'public' section of Jethro isn't enabled, the ical URL actually just contains a HTML error message:

 <p>The public area is not enabled for this Jethro System.  You may like to view the <a href="https://jethro/members">members area<a>

Feeding this URL to a calendar app will result in a validation error.

[tbar0970]

Sounds like we need to make this call an exception to the "public area enabled" setting.

[tbar0970]

Having looked into this, I think the best plan is to add a new system setting to control whether ical feeds are enabled. If it's set to "yes" then they work even if the rest of the public area is disabled. If it's set to "no", users are not offered the chance to subscribe to ical feeds.

While I was in the area I remembered that we have a second type of ical feed available, which shows not roster assignments but all services - public/calls/call_services_ical.class.php

Question for @eb3nezer who originally developed this - are you personally using the "all services" ical feed? I'm pretty confident nobody else is, since it's not publicised anywhere. If you're not using it, I'd quite like to remove it so we're not publicly exposing data without people realising.

[eb3nezer]

Hey @tbar0970. No I'm not using it.