Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved email validation #156

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Improved email validation #156

merged 1 commit into from
Jul 24, 2023

Commits on Jul 22, 2023

  1. (refactor) can test on macos without ios build errors

    (refactor/feat) improved email detection and added domain detection
    
    (refactor) adjust cyclical complexity due to swiftlint warning
    
    (refactor) mark availability of test
    
    (refactor) updated xcode to match the file adjustments made from within spm
    
    (refactor) swiftlint works when building in xcodeproj
    
    might have been an m1 issue, but the build script didn't know the path for swiftlint and failed the build
    
    (fix) restrict domain validation to correct versions
    
    (fix) CI env settings
    
    (refactor) run SPM tests in ci
    
    (nit) line length
    
    (fix) platform requirements for ci tests
    
    (refactor) specifc macos runner os
    
    (refactor) simplify the iphone test
    
    (refactor) xcode select before doing anything and tweak other test commands
    
    (fix) quotes
    
    (fix) key/value format
    
    (refactor) tweak xcode path
    
    (refactor/test) try switch macos and spm targets
    
    (fix) remove space in platform names
    
    (refactor/debug) print current xcode select before changing
    
    (feat) created watch os tests
    
    (refactor) support tests in watchos scheme
    
    (nit) documentation comment style
    
    (nit) address swiftlint function length warning
    
    (nit) address swiftlint switch indentation warning
    
    (nit) swiftlint line length
    
    (nit) remaining swiftlint warnings
    
    disabled them because the algorithm is necessarily complex, so the complexity issue is unfortunate but necessary. The line length is a side effect of that (I COULD put the parseemailsections method outside the current placement of being embedded, but it's only ever used for email validation, so I think this is better code org)
    
    (nit) specify file as space indentation
    
    (nit) indentation
    
    (nit) bonus swiftlint warning
    
    (refactor) add to changelog and readme
    
    (fix) remove file from watchos tests with incompatibilities
    
    (refactor) removed unnecessary sequence requirement on cicd
    
    (refactor) address swiftlint linelength issues AND fix deprecated minimum versions
    
    (refactor) run a current version of swiftlint in cicd
    
    (fix) include watchos files
    
    (fix) add brew to path in swiftlint runner
    
    (fix) remove watchos incompatible files
    
    (fix) watchos incompatibility
    
    (refactor) output swiftlint to github
    
    ... hopefully!
    
    (nit) swiftlint warnings
    
    (fix) watchos test build
    
    (nit) indentation
    
    (nit) swiftlint line length
    
    (nit) indentation
    mredig committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    b5c239e View commit details
    Browse the repository at this point in the history