Skip to content

Commit

Permalink
Fix f2a3821
Browse files Browse the repository at this point in the history
  • Loading branch information
@tbarbette
tbarbette committed Nov 15, 2018
1 parent f2a3821 commit 2191f9c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion elements/icmp/icmpsendpings.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ ICMPPingSource::make_packet(WritablePacket *q)
q->set_ip_header(nip, sizeof(click_ip));
q->timestamp_anno().assign_now();

if (p && _receiver)
if (q && _receiver)
_receiver->send_timestamp[icp->icmp_sequence] = q->timestamp_anno();

return q;
Expand Down

2 comments on commit 2191f9c

@pallas
Copy link
Collaborator

@pallas pallas commented on 2191f9c Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@pallas
Copy link
Collaborator

@pallas pallas commented on 2191f9c Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er, sorry, another bad merge. I need to bump my code up to this repo. The above change makes no sense to being with, since we're already derefing q. I think fuzzy patching is to blame, & me for jumping the gun on the test robot.

Please sign in to comment.