Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More packet memory stuff #141

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

More packet memory stuff #141

wants to merge 5 commits into from

Commits on Nov 15, 2018

  1. click/etherswitch: bail out on OOM 

    Change-Id: Iedfff2d0be5fb8686a28fd8acb775c94f2fd7e63
Reviewed-on: https://gerrit.ikarem.io/74140
Static-Analysis: Jenkins Build System <jenkins@meraki.com>
Tested-by: Jenkins Build System <jenkins@meraki.com>
Reviewed-by: Peter Hurley <peter@meraki.com>
Signed-off-by: Derrick Pallas <pallas@meraki.com>
    Derrick Pallas committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    a4caeb1 View commit details
    Browse the repository at this point in the history

  2. click/fromfile: plug mmap leak in error path 

    If mmap is successful but Packet::make fails to create a new SKB, we need to
execute the destructor we passed to Packet::make.  It actually might make
sense to do this in Packet::make instead instead of the caller, not sure
which is better.

Change-Id: If97d221daf3443003f40097cc36f7410bb544669
Reviewed-on: https://gerrit.ikarem.io/74137
Static-Analysis: Jenkins Build System <jenkins@meraki.com>
Tested-by: Jenkins Build System <jenkins@meraki.com>
Reviewed-by: Peter Hurley <peter@meraki.com>
Signed-off-by: Derrick Pallas <pallas@meraki.com>
    Derrick Pallas committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    1868fae View commit details
    Browse the repository at this point in the history

  3. click/hashtable: assert that operator[] does not return a NULL reference 

    There is no such thing as a NULL reference, so there is no way to tell if
find_insert failed when invoked by operator[].  Some old code attempted to
check !&x for the reference, but the compiler can optimize it out since it
is "impossible" according to the ARM.  Therefore, we should just assert that
find_insert succeeds.

Change-Id: I1d34e19033e77dd6aebfdba76d553e927711a62c
Signed-off-by: Derrick Pallas <pallas@meraki.com>
    Derrick Pallas committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    7aec8b8 View commit details
    Browse the repository at this point in the history

  4. click/icmp: bail out on OOM 

    Change-Id: Ia7b9f3c4a4e7547d17251edac67c75f967507b3f
Reviewed-on: https://gerrit.ikarem.io/74139
Static-Analysis: Jenkins Build System <jenkins@meraki.com>
Tested-by: Jenkins Build System <jenkins@meraki.com>
Reviewed-by: Peter Hurley <peter@meraki.com>
Signed-off-by: Derrick Pallas <pallas@meraki.com>
    Derrick Pallas committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    f2a3821 View commit details
    Browse the repository at this point in the history

  5. Fix f2a3821

    @tbarbette
    tbarbette committed Nov 15, 2018
    2 Configuration menu
    Copy the full SHA
    2191f9c View commit details
    Browse the repository at this point in the history