-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test reorganisation (results part) #29
Conversation
Thanks for your PR. I'll check the issues you observed. As for the MATLAB test files and M scripts. I have no MATLAB on Linux available which can run these tests. So, it would be nice, if you are apparently able to run them, to open issues for them. They should not fail. And yes moving them from the AT files to test/matlab is fine for me. |
Please add all files of test/results to the distribution. Thanks |
I do not understand your last comment. The files have been added.... |
No problem. I can do it. I think I also found a fix for the EOL issue on Win. |
Why is it |
Files mat73_read_le.at and mat73_read_be.at miss |
Well, as far as I understand AT_CLEANUP once had arguments and there were such calls. So I expected that AT_CLEANUP was clening the files in argument. It does not. So the proper call is just AT_CLEANUP. I intended to do that but forgot for some files. Consider it done with a next patch. |
For the missing miss AT_SKIP_IF, I suspect they were already missing before. Unless I made a mistake, I did not touch anything with this respect. |
I already extended your changes. I can do it for these two follow-on changes. |
Your questions
|
Some tests are not yet reorganized. Are you doing it or did you left it for me? |
I'm doing it.... But it's a little bit more difficult for me as matlab tests are so slow.... But progressing.... Note that some tests are currently blocking, I'll correct that. |
* Yield same output as empty character array of HDF5 MAT file * As reported by #29
* Yield same output as empty character array of HDF5 MAT file * As reported by #29
Third issue is fixed by 16bb5e8. |
Great !!! |
* Yield same output as empty character array of HDF5 MAT file * As reported by tbeu#29
Here is a first step in tests reorganisation. I split all tests results in files (in test/results) and completely removed the use of MATIO_AT_HOST. You can find there are some small discrepancies between the output between the {4,5,7.3} versions. Most of them were removed with my previous patch, but some of them subsist. There are 3 types of discrepancies:
All such discrepancies can be seen with "ls -5 -73" and then compare those files with the ones with the -5 -73 removed.
A next step would be to remove the matlab test files (in test/matlab). I have some test failures when running the matlab tests. Is this normal ?
Then we can maybe generate the testsuite (.at) files from templates (I found some small discrepancies between the various {4,5,73} and {compressed,uncompressed}).
Anyway, this is already a huge improvement (in my view) and can be pulled independently, thus this pull request (a real one this time).